[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

Mon Sep 26 14:43:21 PDT 2022

aaron.ballman added a comment.

In D134550#3816255 <https://reviews.llvm.org/D134550#3816255>, @jhuber6 wrote:

> In D134550#3816239 <https://reviews.llvm.org/D134550#3816239>, @aaron.ballman wrote:
>
>> In terms of this patch -- is there sentiment to revert (even temporarily while we discuss)?
>
> I think alternatively we could just change the message to mention that the provided flag matches a CC1 option without the suggestion. Then developers and users would know that they probably got something wrong but won't be encouraged to use the CC1 option directly.

Does the existing "unknown argument 'whatever'" diagnostic make it sufficiently clear that they probably got something wrong, though?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134550/new/

https://reviews.llvm.org/D134550