[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

Jennifer Yu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 14:27:55 PDT 2022


jyu2 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8561-8617
     for (const auto *Cl : Clauses) {
       const auto *C = dyn_cast<OMPUseDevicePtrClause>(Cl);
       if (!C)
         continue;
       for (const auto L : C->component_lists()) {
         OMPClauseMappableExprCommon::MappableExprComponentListRef Components =
             std::get<1>(L);
----------------
ABataev wrote:
> Can you try to merge these 2 blocks somehow, they are very similar
Should I do this with NFC in next patch.  Or should I change now.
Thanks,

Jennifer


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134556/new/

https://reviews.llvm.org/D134556



More information about the cfe-commits mailing list