[PATCH] D134653: [clang][modules] Over-align the `Module` class

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 10:35:29 PDT 2022


jansvoboda11 marked an inline comment as done.
jansvoboda11 added a comment.

In D134653#3815672 <https://reviews.llvm.org/D134653#3815672>, @srj wrote:

> FYI, adding this patch to my local build does allow me to *compile* properly now. I haven't tested for correctness.

Thanks for verifying the build. You can test for correctness by "building" the `check-clang` target.

In D134653#3815648 <https://reviews.llvm.org/D134653#3815648>, @srj wrote:

> Regarding presubmit testing, that's of great concern to me; if LLVM isn't testing on x86-32 then it's not really *supporting* x86-32 anymore (as a compilation host anyway), and that's a rather large change to make without warning. Do you know to whom I should escalate that concern?

You can contact the infrastructure working group. Note that we run more configurations post-commit: https://lab.llvm.org/buildbot/#/console


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134653/new/

https://reviews.llvm.org/D134653



More information about the cfe-commits mailing list