[PATCH] D134653: [clang][modules] Over-align the `Module` class

Steven Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 10:18:55 PDT 2022


srj added inline comments.


================
Comment at: clang/include/clang/Basic/Module.h:96
 /// Describes a module or submodule.
-class Module {
+class alignas(8) Module {
 public:
----------------
Probably worth a comment here, it's not necessarily obvious to the reader that this is to fix a 32-bit pointer issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134653/new/

https://reviews.llvm.org/D134653



More information about the cfe-commits mailing list