[PATCH] D133574: [C2x] reject type definitions in offsetof

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:3279
                  bool IsTypeSpecifier, bool IsTemplateParamOrArg,
+                 bool IsWithinOffsetOf, bool IsOffsetOfInMacro,
                  SkipBodyInfo *SkipBody = nullptr);
----------------
inclyc wrote:
> aaron.ballman wrote:
> > Instead of passing two `bool`s, why not pass `Parser::OffsetOfStateKind` directly?
> `Parser::OffsetOfStateKind` is not visible to class `Sema`?
Sure, but it's a new enum, so we can put it into `Sema` if we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133574/new/

https://reviews.llvm.org/D133574