[PATCH] D133574: [C2x] reject type definitions in offsetof

YingChi Long via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 08:23:00 PDT 2022


inclyc added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:3279
                  bool IsTypeSpecifier, bool IsTemplateParamOrArg,
+                 bool IsWithinOffsetOf, bool IsOffsetOfInMacro,
                  SkipBodyInfo *SkipBody = nullptr);
----------------
aaron.ballman wrote:
> Instead of passing two `bool`s, why not pass `Parser::OffsetOfStateKind` directly?
`Parser::OffsetOfStateKind` is not visible to class `Sema`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133574/new/

https://reviews.llvm.org/D133574



More information about the cfe-commits mailing list