[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

Mon Sep 26 06:56:45 PDT 2022

sgraenitz added a comment.

In D134441#3814794 <https://reviews.llvm.org/D134441#3814794>, @fhahn wrote:

> LGTM, thanks! You might want to extend the windows check lines to the other tests as well.

Thanks. Yes thought about that, but not all of them match the typical IR output on Windows (gxx_personality, cfi, etc.). The test case that I extended is exactly the scenario we were running into and for the moment it seems good enough to make sure we don't regress again. I will keep the review open for a day or two before landing this -- in case there is more feedback.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134441/new/

https://reviews.llvm.org/D134441