[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 04:59:10 PDT 2022


mstorsjo added a comment.

Nice, +1 this looks reasonable to me. I've run into similar issues occasionally with mingw builds with dylib enabled too, where (depending on how the linker ends up pulling in objects) you can end up with duplicate definitions etc.

I would expect that this also fixes the somewhat surprising issue, where building clang-tblgen alone ends up building way way more object files than expected, if dylibs are enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134637/new/

https://reviews.llvm.org/D134637



More information about the cfe-commits mailing list