[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 25 17:22:36 PDT 2022


ychen added a comment.

In D134542#3814029 <https://reviews.llvm.org/D134542#3814029>, @erichkeane wrote:

> Thanks for the quick review!  Yeah, that case is a tough one, we don't really have a good way of determining whether that was supposed to fail, or be the best match.  GCC does the option of just treating it as failed, so it'll have the problem that I mentioned above.  No idea what MSVC is doing though.... thats frightening.

This paper (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2429r0.pdf) makes me like the current approach more. Basically, we better strive for intuitive diagnostics instead of diagnosing as many errors as possible but run the risk of lower-quality diagnostic messages.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134542/new/

https://reviews.llvm.org/D134542



More information about the cfe-commits mailing list