[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

Sat Sep 24 06:08:54 PDT 2022

aaron.ballman added a comment.

Thank you for this, I think it's a good idea! Can you also add a release note for the changes?

This mostly LG to me but I did spot one thing I was curious about.

================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291
   Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6));   // LocEnd
+  Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 3));   // Default/DeleteLoc
   Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 32)); // ODRHash
----------------
Should this be using `6` instead of `3` as with the other location fields? (`InnerLocStart`, `LocEnd`) And if so, we should probably add some test coverage for this bit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134549/new/

https://reviews.llvm.org/D134549