[PATCH] D134544: [clang-cl] Implement /ZH: flag

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:344
 
+/// Set debug info source file hashing algorithm
+ENUM_CODEGENOPT(DebugSrcHashAlgorithm, SrcHashAlgorithm, 2, CSK_MD5)
----------------
hans wrote:
> ultra nit: period. But maybe the comment is superfluous?
Seems superfluous to me too, but this file is very consistent about having superfluous comments for every option. I'll add the trailing period.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:106
+  enum SrcHashAlgorithm {
+    CSK_MD5,
+    CSK_SHA1,
----------------
hans wrote:
> what does CSK stand for here?
I'm guessing "check sum kind", but I don't know :)

`SHA_` looks a bit funny as prefix too...

I also don't love the cc1 flag name, but I figured it's a bit bikesheddy and it's internal only so i kept it as is.

If you have a preference for flag name, enum name, and enum prefix, let me know.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134544/new/

https://reviews.llvm.org/D134544