[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Fri Sep 23 12:34:49 PDT 2022

Matt added inline comments.

================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:239
+AARCH64_CPU_NAME("neoverse-v2", ARMV9A, FK_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_SVE | AArch64::AEK_SVE2 | AArch64::AEK_SSBS |
+                  AArch64::AEK_FP16 | AArch64::AEK_BF16 | AArch64::AEK_RAND |
----------------
Should `AEK_SVE2BITPERM` be present? (Noticed that N2 has ` AArch64::AEK_SVE2 | AArch64::AEK_SVE2BITPERM`).

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:1111
+                                       FeaturePerfMon, FeatureETE, FeatureMatMulInt8,
+                                       FeatureNEON, FeatureSVE2BitPerm, FeatureFP16FML,
+                                       FeatureMTE, FeatureRandGen];
----------------
`FeatureNEON` may be redundant (note that it's in `HasV8_3aOps`).

OTOH, `NeoverseV1` also has `FeatureCrypto`: is this no longer the case for `NeoverseV2`?

================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:202
   case NeoverseN2:
+  case NeoverseV2:
     PrefFunctionLogAlignment = 4;
----------------
Are `CacheLineSize` (`= 0` by default) and `MaxInterleaveFactor` (`= 2` by default) the same / correct for both N2 and V2?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134352/new/

https://reviews.llvm.org/D134352