[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 23 11:47:08 PDT 2022


aaron.ballman added a comment.

This is a neat idea, but I think we should think about it carefully. In general, `-Xclang` is not something we want to actively recommend users use, so do we really want to make it easier for users to use?

One potential problem that could be caused by this change is when we have a driver option that the user typos but happens to match a -cc1 argument; I could see inattentive users going "cool, I'll add -Xclang then" instead of fixing the driver arg; but I've not looked through our existing options to see if that situation is particularly *likely* or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134550/new/

https://reviews.llvm.org/D134550



More information about the cfe-commits mailing list