[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

Jennifer Yu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 23 11:15:46 PDT 2022


jyu2 created this revision.
jyu2 added reviewers: ABataev, jdoerfert, mikerice.
jyu2 added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
jyu2 requested review of this revision.
Herald added subscribers: openmp-commits, cfe-commits, sstefan1.
Herald added a project: clang.

It is due to data mapping ordering.

According omp spec:
If one or more map clauses are present, the list item conversions that are performed for any use_device_ptr or use_device_addr clause occur after all variables are mapped on entry to the region according to those map clauses.

The change is to put mapping data for use_device_addr at end of data mapping array.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134556

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/test/OpenMP/target_data_codegen.cpp
  openmp/libomptarget/test/mapping/target_use_device_addr.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134556.462550.patch
Type: text/x-patch
Size: 6589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220923/5afb52bf/attachment-0001.bin>


More information about the cfe-commits mailing list