[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

[Mark de Wever via Phabricator via cfe-commits]

Mordante added a comment.

When I implemented P0479R5 I didn't look at earlier revisions of the paper. I'm a bit surprised to see revision 2 had a lot more information. (At that time I was less familiar with WG21 papers, so I didn't consider looking at older papers or notice the missing revision history.) I agree with @aaron.ballman's observation; revision 2 is unclear what the best solution regarding overriding PGO is.

I'm not really active in Clang at the moment so I feel @aaron.ballman has a better view of which approach to take for ``[[likely]]`` and PGO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134456/new/

https://reviews.llvm.org/D134456