[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

> The number of people likely to notice that PS4 is different from the other targets seems far smaller than the number of people noticing the same for Windows. But I've got no data to back that up, either.

heh.  There's a PS4 bot that notices.  But the PS4 situation is also different in that there is only one toolchain.  When you have multiple toolchains with different defaults, as is the case with Windows, then you have users getting annoyed or possibly into trouble.

FTR, we (Sony) did a huge pile of work some years ago to make a lot of the C++ tests dialect-agnostic (run with different values of `-std`, do a lot of `#if __cplusplus <= ...` for different dialects, like that).  There are really very few tests that actively care what the default is.  I think we just very recently added one specific to PS4.  I am not surprised that there isn't an equivalent for Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465