[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Fri Sep 23 01:27:13 PDT 2022

dmgreen added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:1112
+                                       FeatureNEON, FeatureSVE2BitPerm, FeatureFP16FML,
+                                       FeatureMTE, FeatureRandGen];
   list<SubtargetFeature> Saphira    = [HasV8_4aOps, FeatureCrypto, FeatureFPARMv8,
----------------
david-arm wrote:
> Matt wrote:
> > Shouldn't `FeatureMTE` (Enable Memory Tagging Extension) be present, too (as in NeoverseN2)?
> It is already included in the patch, i.e. see above:
> 
>   FeatureMTE, FeatureRandGen];
Oh yeah so it is. Should we add AEK_MTE too then?

================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1033
+                AArch64::AEK_RCPC | AArch64::AEK_CRC | AArch64::AEK_FP |
+                AArch64::AEK_SIMD | AArch64::AEK_RAS | AArch64::AEK_LSE |
+                AArch64::AEK_RDM | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD |
----------------
RAS is here twice.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134352/new/

https://reviews.llvm.org/D134352