[PATCH] D128142: [MemProf] Memprof profile matching and annotation

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 22 18:30:53 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247
+                                uint32_t Column) {
+  return hash_combine(Function, LineOffset, Column);
+}
----------------
MaskRay wrote:
> You may use BLAKE3 instead of MD5. BLAKE3 is much faster than LLVM's slow MD5 implementation.
llvm/include/llvm/Support/xxhash.h is also a good choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128142/new/

https://reviews.llvm.org/D128142



More information about the cfe-commits mailing list