[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added a comment.

This is looking great. Thank you for all your work iterating on this.

Please update the description to reflect the changes in implementation.



================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:120
+
+void addResourceBinding(GlobalVariable *GV, CGHLSLRuntime::Buffer &CB) {
+  // FIXME: add resource binding to GV.
----------------
Please remove the empty function. We can add it when it does something. Also make sure we have an issue for the FIXME.


================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:141
+
+  // FIXME: support packoffset.
+  uint32_t Offset = 0;
----------------
Please file an issue for this or link to the issue if it exists.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130131/new/

https://reviews.llvm.org/D130131