[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

Brian Sumner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 22 11:52:14 PDT 2022


b-sumner added a comment.

In D134355#3809294 <https://reviews.llvm.org/D134355#3809294>, @yaxunl wrote:

> In D134355#3807435 <https://reviews.llvm.org/D134355#3807435>, @cfang wrote:
>
>> LGTM
>>
>> Should the module flag name be amdgpu_code_object_version or amdhsa_code_object_version?
>
> Good question.
>
> @b-sumner Does code object version affects PAL? Thanks.

It should, we use the same code objects on PAL and ROCm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134355/new/

https://reviews.llvm.org/D134355



More information about the cfe-commits mailing list