[PATCH] D134248: [clang][modules][deps] Preserve module map load order

Michael Spencer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 22 11:21:11 PDT 2022


Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:129
+    // TODO: Track these as `FileEntryRef` to simplify the equality check.
+    auto A = ScanInstance.getFileManager().getFile(Deps.ClangModuleMapFile);
+    auto B = ScanInstance.getFileManager().getFile(ModuleMapFile);
----------------
This is loop invariant and can be pulled out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134248/new/

https://reviews.llvm.org/D134248



More information about the cfe-commits mailing list