[PATCH] D134326: [HLSL] Allow SV_GroupIndex for lib profile.

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 21 08:35:09 PDT 2022


beanz added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6901
+    // FIXME: it is OK for a compute shader entry and pixel shader entry live in
+    // same HLSL file.
     uint32_t Pipeline =
----------------
I think the underlying issue here is that some attributes should only be validated on entry points that are being compiled as entry points in the current compilation action. Please file a GitHub issue for this and put the issue URL in the comment here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134326/new/

https://reviews.llvm.org/D134326



More information about the cfe-commits mailing list