[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

Dave Green via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 21 06:39:35 PDT 2022


dmgreen added a comment.

The arm_acle.h header is shared across Arm and AArch64 - they use the same builtin names even if they are replicated to a certain degree across the backends. As this is used in both it would be good to fix them at the same time. It doesn't need to change the guards as D133359 <https://reviews.llvm.org/D133359> does, the better error message from TARGET_BUILTIN is a good starts (and helps to simplify D133359 <https://reviews.llvm.org/D133359>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134127/new/

https://reviews.llvm.org/D134127



More information about the cfe-commits mailing list