[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 21 06:38:21 PDT 2022
arsenm added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:590-591
// times 100.
- // ToDo: Enable module flag for all code object version when ROCm device
- // library is ready.
- if (getTarget().getTargetOpts().CodeObjectVersion == TargetOptions::COV_5) {
+ if (getTarget().getTargetOpts().CodeObjectVersion !=
+ TargetOptions::COV_None) {
getModule().addModuleFlag(llvm::Module::Error,
----------------
What is the flag default value? What does it mean to target none?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134355/new/
https://reviews.llvm.org/D134355
More information about the cfe-commits
mailing list