[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 21 04:19:24 PDT 2022


HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.

Thanks for the fix.

In D134325#3804969 <https://reviews.llvm.org/D134325#3804969>, @MyDeveloperDay wrote:

> given that #57538 manifested itself as a incorrect format (no doubt because of incorrect  token annotation), should we add a verifyFormat tests somewhere for the example from the github issue, (it just protects the formatting for being broken by some other change)

Yeah we disagree here, but I have to redisagree.
It's the wrong annotation, it's not related to any formatting. And the format tests cpp is a monster.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134325/new/

https://reviews.llvm.org/D134325



More information about the cfe-commits mailing list