[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

Azat Khuzhin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 20 13:49:46 PDT 2022


azat added a comment.

> If the two patches are basically identical with just some fixes for the problem, the convention is to reuse the original Differential.

Ok, did not know that, will keep it in mind, thanks!

> You can click "Add Action - Open" (or Reopen?), then you can upload a new patch to update the Differential.

Actually I don't have such actions.

> This keeps all discussions in one place and keeps are reviewers and interested folks aware.

Yeah, that's a good point, but by some reason I though that it is not possible/good to update already landed revision...

P.S. the resubmit version already have some comments too, maybe it will be better to continue there? But I'm not against close it and move it here, if this is preferable and someone can reopen it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133092/new/

https://reviews.llvm.org/D133092



More information about the cfe-commits mailing list