[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 20 13:40:27 PDT 2022


leonardchan added inline comments.


================
Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1
+;; Check the cases involving dso_local_equivalent where we do expect functions to be merged.
+; RUN: opt -S -mergefunc < %s | FileCheck %s
----------------
nikic wrote:
> Based on your check lines, it doesn't look like the functions actually get merged? You probably need to add some dummy instructions to pass the instruction threshold, or use internal linkage.
Woops. Yeah you're right. Updating the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134300/new/

https://reviews.llvm.org/D134300



More information about the cfe-commits mailing list