[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

Tue Sep 20 02:48:17 PDT 2022

t.p.northover closed this revision.
t.p.northover added a comment.

Just noticed it'd already been approved with those suggestions, so pushed the revised version: 4388b56d <https://reviews.llvm.org/rG4388b56d525c08ce3cf941cfbad2428b0e1695b0> and 58f9abaed4aa <https://reviews.llvm.org/rG58f9abaed4aa148566d5f14afdf473e57b20d687>.

================
Comment at: clang/include/clang/Driver/ToolChain.h:111

+  enum UnwindTableLevel {
+    UTL_None,
----------------
MaskRay wrote:
> I'd prefer `enum class` without the `UTL_` prefix. That will be more readable. `UTL` isn't very clear (`RM_Enabled` is kinda a bad name as without `RTTIMode` it's clear what's enabled; `UNW_CompilerRT` is fine as from CompilerRT/Libgcc we know it refers to the unwind or builtin library; Asynchrounous/Synchronous is not very clear).
Makes sense now that we have classes.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131153/new/

https://reviews.llvm.org/D131153