[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.
Paul Kirth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 19 15:22:55 PDT 2022
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
Thanks for the code cleanup. The patch is LGTM, with some small nits.
================
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:240
+TypeInfo getTypeInfoForType(const QualType &T) {
+ if (const TagDecl *TD = getTagDeclForType(T)) {
+ InfoType IT;
----------------
nit: can we invert this condition and use an early return to reduce nesting?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134225/new/
https://reviews.llvm.org/D134225
More information about the cfe-commits
mailing list