[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

Evgeny Shulgin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 19 12:39:57 PDT 2022


Izaron updated this revision to Diff 461312.
Izaron added a comment.

Removed whitespaces in comments.

P.S. I wonder if smaller review requests will make things better? Say a review request for `fmax`+`fmin`, then a new one for `ilogb`+`logb`, then for `scalbn`.
This may lead to a more understandable and robust review process =)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134136/new/

https://reviews.llvm.org/D134136

Files:
  clang/docs/LanguageExtensions.rst
  clang/lib/AST/ExprConstant.cpp
  clang/test/Sema/constant-builtins-math.cpp
  llvm/include/llvm/ADT/APFloat.h
  llvm/lib/Support/APFloat.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134136.461312.patch
Type: text/x-patch
Size: 6969 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220919/90ccb74c/attachment.bin>


More information about the cfe-commits mailing list