[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 19 08:26:20 PDT 2022


beanz added a comment.

We should also have a library test case that verifies that the `global_dtors` variable is kept.



================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:50
   void annotateHLSLResource(const VarDecl *D, llvm::GlobalVariable *GV);
-  void generateGlobalCtorDtorCalls();
+  void generateGlobalCtorDtorCalls(llvm::Triple &T);
 
----------------
You don't need to pass the triple in here. If you have the module, you have the triple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133993/new/

https://reviews.llvm.org/D133993



More information about the cfe-commits mailing list