[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

Mon Sep 19 06:55:59 PDT 2022

erichkeane added a comment.

Thanks for taking this over!  FIRST, please make sure you re-submit this with the entire 'context' (see context-not-available), by making sure you use -U999999 on your patch before uploading it.

It DOES appear from the tests that we're already checking everything we're supposed to?

ALSO, could you please try rebasing this on top of "https://reviews.llvm.org/D126907" to see if it causes any further issues for that?  I'm nearing a solution to my last problem on that, and would love to get that submitted in the next week or two, and knowing if this/these tests are going to break it would be an appreciated heads-up.

================
Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:39
+S4<X> s41;
+S4<Y> s42; // expected-error{{template template argument 'Y' is more constrained than template template parameter 'P'}}
+S4<Z> s43;
----------------
I realize the rest of the test does a poor job of this, but can you better arrange the new diagnostics for me, rather thanputting the 'note's on teh individual lines?  

I prefer to have them in 'emitted order' next to the error/warning that caused the notes. You can do an "@" on 'expected-note' that refers to a different line by putting a `// #SOME_BOOKMARK_NAME` on the line that has the note, and `expected-note@#SOME_BOOKMARK_NAME` here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134128/new/

https://reviews.llvm.org/D134128