[PATCH] D134137: [clangd] Return earlier when snippet is empty
Tom Praschan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 19 02:53:35 PDT 2022
tom-anders marked an inline comment as done.
tom-anders added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017
+TEST(CompletionTests, EmptySnippetDoesNotCrash) {
+ // See https://github.com/clangd/clangd/issues/1216
----------------
nridge wrote:
> Does this test trigger the crash for you when run without the fix?
Yes it does, I double checked. Not sure why it didn't work for you
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134137/new/
https://reviews.llvm.org/D134137
More information about the cfe-commits
mailing list