[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

[Paulo Matos via Phabricator via cfe-commits]

pmatos marked 2 inline comments as done.
pmatos added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:954
         10, // wasm_externref,
+        20, // wasm_funcref
     };
----------------
aaron.ballman wrote:
> pmatos wrote:
> > aaron.ballman wrote:
> > > Where did this value come from?
> > Unsure what you mean here. This is the address space number we also use on the LLVM side.
> > Unsure what you mean here. This is the address space number we also use on the LLVM side.
> 
> That's exactly what I was looking for -- I wanted to make sure this agreed with the LLVM side of things and any public documentation about address spaces for WASM.
> > Unsure what you mean here. This is the address space number we also use on the LLVM side.
> 
> That's exactly what I was looking for -- I wanted to make sure this agreed with the LLVM side of things and any public documentation about address spaces for WASM.

Sure! Marking as done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128440/new/

https://reviews.llvm.org/D128440