[PATCH] D132285: [Clang][LoongArch] Implement ABI lowering

Renato Golin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 17 12:10:53 PDT 2022


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

I can't vouch for your ABI correctness, but you seem to have a lot of tests covering what you claim to have implemented, so looks good to me.

Thanks for opening an issue for RISC-V.

Clang's TargetInfo.cpp is really large, perhaps we should think about splitting it across different targets, but definitely NOT for this review.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132285/new/

https://reviews.llvm.org/D132285



More information about the cfe-commits mailing list