[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 17 06:39:36 PDT 2022


njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.

LGTM, just with one small testing nit



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-values.cpp:533
+  int *np_local0[2] = {nullptr, nullptr};
+  // CHECK-NOT-FIXES: int * const np_local0[2]
+  
----------------
This not fixes line is pretty redundant, and unstable. If you really want to ensure no fix was generated, you can do a check-fixes with the original line contents. But as there is no warning generated here there shouldn't be a need to check for any fix behaviour, same goes below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130793/new/

https://reviews.llvm.org/D130793



More information about the cfe-commits mailing list