[PATCH] D133887: [Clang] Support label at end of compound statement

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 17 04:22:41 PDT 2022


cor3ntin added a comment.

In D133887#3797491 <https://reviews.llvm.org/D133887#3797491>, @Izaron wrote:

>> It should definitely be without warning in C23 mode and give an extension warning in earlier modes.
>
> @aaron.ballman we have this extension warning for pre-C++23:
>
>   def ext_label_end_of_compound_statement : ExtWarn<
>     "label at end of compound statement is a C++2b extension">,
>      InGroup<CXX2b>;
>
> Should I add a new warning for pre-C23? We could have two warnings for each language:
>
>   ext_cxx_label_end_of_compound_statement
>   ext_c_label_end_of_compound_statement

I think that's reasonable, yes - given that we need different warning groups


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133887/new/

https://reviews.llvm.org/D133887



More information about the cfe-commits mailing list