[PATCH] D133634: [clang] Allow vector of BitInt

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 16 22:20:13 PDT 2022


craig.topper added a comment.

In D133634#3795044 <https://reviews.llvm.org/D133634#3795044>, @erichkeane wrote:

> The CFE Changes look correct, but @eli.friedman/@craig.topper should comment as to whether this is acceptable.

This is acceptable to me.



================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:3111
     Extra.mangleSourceName("__vector");
-    Extra.mangleType(QualType(ET, 0), Range, QMM_Escape);
+    Extra.mangleType(QualType(ET ? static_cast<const Type *>(ET) : BitIntTy, 0),
+                     Range, QMM_Escape);
----------------
Why is an explicit cast needed here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133634/new/

https://reviews.llvm.org/D133634



More information about the cfe-commits mailing list