[PATCH] D134067: [HLSL] Enable availability attribute

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaAvailability.cpp:198
+    return Triple.getVendor() == llvm::Triple::Apple ||
+           Triple.getOS() == llvm::Triple::ShaderModel;
   }
----------------
This should jsut be a 'case' label added above, we are already switching on getOS.


================
Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:10
+
+// expected-note@* {{'WaveActiveCountBits' has been marked as being introduced in HLSL ShaderModel 6.0 here, but the deployment target is HLSL ShaderModel 5.0}}
----------------
Not sure how I feel about us testing the headers AND functionality in the same place.   @aaron.ballman : Does this seem inappropriate to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134067/new/

https://reviews.llvm.org/D134067