[PATCH] D134054: [clang][Interp] Properly destruct allocated Records
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 16 10:30:12 PDT 2022
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Program.h:48
+ // here manually so they are properly freeing their resources.
+ for (auto It : Records)
+ It.second->~Record();
----------------
erichkeane wrote:
> I SUSPECT that by a reading of our rules here, we aren't allowed to use `auto` here. That said, I'm sure I don't want to have you spell out the whole LHS.
>
> THOUGH the name "It" is a little misleading, as this is NOT an iterator, it ends up being a std::pair or something I think...
Would `RecordPair` be better?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134054/new/
https://reviews.llvm.org/D134054
More information about the cfe-commits
mailing list