[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: clang/test/Driver/config-file3.c:44
+
+//--- --no-default-config disables config search
+//
----------------
Append `.` after a complete sentence in a comment.


================
Comment at: clang/test/Driver/config-file3.c:49
+// NO-DEFAULT-CONFIG-NOT: Configuration file:
+//
 //--- Invocation qqq-clang-g++ tries to find config file qqq.cfg if qqq-clang-g++.cfg is not found.
----------------
mgorny wrote:
> MaskRay wrote:
> > mgorny wrote:
> > > MaskRay wrote:
> > > > The convention doesn't use otherwise empty `// `. The file does not obey the convention but your new lines can drop the empty `//`
> > > Do you mean the extra space or the entire empty line?
> > I mean `^// *$`, which typically makes the test harder to browse.
> > 
> > (Think of `{` `}` in vim. If every line has `//`, `{` `}` isn't effective at all.)
> Oh, so you mean to have empty lines between tests to make it easier to navigate between tests? Please let me know if I got this right.
Thanks, this looks better. I think the convention is not to even leave `^//$` between RUN and CHECK, but the current form is already good enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134018/new/

https://reviews.llvm.org/D134018