[PATCH] D133941: [clang][Interp] Record item types in InterpStack

Thu Sep 15 07:46:32 PDT 2022

tbaeder added a comment.

In D133941#3792330 <https://reviews.llvm.org/D133941#3792330>, @erichkeane wrote:

> Can you clarify what the intent of this patch is?  Perhaps I'm just being slow today, but I don't really get the intent here.

Consider:

  push<Pointer>(...);
  (lots of stuff)
  pop<int>();

currently this would just work and give you an integer, but they value wouldn't make any sense. This patch would assert here since the value on the stack is not an integer, it's a pointer.
It basically adds a bit of type-safety back.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133941/new/

https://reviews.llvm.org/D133941