[PATCH] D128462: [HLSL] add -I option for dxc mode.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6362
 
-def cl_Group : OptionGroup<"<clang-cl options>">, Flags<[CLOption]>,
+def cl_Group : OptionGroup<"<clang-cl options>">, Flags<[CLDXCOption]>,
   HelpText<"CL.EXE COMPATIBILITY OPTIONS">;
----------------
kadircet wrote:
> i am failing to understand the semantics of this new option group, and it's causing regressions in clangd. see https://github.com/clangd/clangd/issues/1292.
> 
> is this new group suppose to serve flags that are available both in `--driver-mode=cl` and `--driver-mode=dxc`? i.e. they are for the flags in the intersection?
> are there any flags that are applicable to CL driver mode but not to the DXC mode (and vice versa)?
> 
> why didn't we go for just adding DXCOption mode into here, if every option in CL mode is actually applicable to DXC option as well, rather than introducing a new option?
DXC does not support all the CL options, and vice versa. There are some shared options, which is what this group tries to capture.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128462/new/

https://reviews.llvm.org/D128462