[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

[Nathan James via Phabricator via cfe-commits]

njames93 added a comment.

What's with the .keep files. Will lit or sphinx fail if the cuda directory doesn't exist, if not I'd be happier removing them(they'd get removed once the first cuda check lands anyway).



================
Comment at: clang-tools-extra/clang-tidy/cuda/CudaTidyModule.cpp:1
+//===--- GoogleTidyModule.cpp - clang-tidy --------------------------------===//
+//
----------------
Google...

It may be easier/safer to use the add_new_check script to generate this, then just remove all the new check specific files.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:98
 --------------------------
 
 New checks
----------------
Put it in here.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:152
 
+- Introduced first checks specifically for CUDA.
+
----------------
This line doesn't belong in the new checks portion of the release notes, just stick it in the general clang-tidy section.
Also maybe just say "Introduce the cuda module for checks specific to cuda code" and remove all the documentation below, That will be filled in when the first check lands.


================
Comment at: clang-tools-extra/docs/clang-tidy/index.rst:143
                                      each source file in its parent directories.
-    --config-file=<string>         - 
+    --config-file=<string>         -
                                     Specify the path of .clang-tidy or custom config file:
----------------
Unnecessary edit can be removed.


================
Comment at: clang-tools-extra/docs/clang-tidy/index.rst:241
     --system-headers               - Display the errors from system headers.
-    --use-color                    - 
+    --use-color                    -
                                     Use colors in diagnostics. If not set, colors
----------------
Ditto.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/cuda/cuda-initializers.h:1
+// CUDA struct types with interesting initialization properties.
+// Keep in sync with clang/test/SemaCUDA/Inputs/cuda-initializers.h.
----------------
What's the purpose of this file here, do you envision many checks requiring to include this?


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/cuda/cuda.h:3
+
+#include <stddef.h>
+
----------------
This looks worrying as test cases don't run with a standard library 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133436/new/

https://reviews.llvm.org/D133436