[PATCH] D132608: [CMake] Clean up CMake binary dir handling
Shilei Tian via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 14 16:06:52 PDT 2022
tianshilei1992 added a comment.
Is it a good idea to define variables starting with `CMAKE`? That might be confusing for later maintenance by other developers because chances are that they will think those variables are CMake provided variables, try to look up into CMake document to see what they are, and then find out they are not at all.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132608/new/
https://reviews.llvm.org/D132608
More information about the cfe-commits
mailing list