[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 14 13:11:14 PDT 2022


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm, nice!



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4452
+
+  if (Arg *A = Args.getLastArg(options::OPT_fms_runtime_lib_EQ)) {
+    StringRef Val = A->getValue();
----------------
This could use llvm::StringSwitch


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4493
+
+  if (/*IsClangCL && */Args.hasArg(options::OPT__SLASH_Zl)) {
+    CmdArgs.push_back("-D_VC_NODEFAULTLIB");
----------------
leftover IsClangCL comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133457/new/

https://reviews.llvm.org/D133457



More information about the cfe-commits mailing list