[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 14 09:54:08 PDT 2022


rnk added a comment.

I agree, there's no reason to change the i686 MSVC record layout algorithm. It was written, tested, done, it's fragile. We used to have some decent continuous integration testing for ABI issues like this, but as usual these things require care and feeding and it did not survive the passage of time.

This patch implements the new GCC behavior, right? Reject arrays when size is not a multiple of alignment? That sounds good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133711/new/

https://reviews.llvm.org/D133711



More information about the cfe-commits mailing list