[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D133800#3789188 <https://reviews.llvm.org/D133800#3789188>, @mgorny wrote:

> In D133800#3789100 <https://reviews.llvm.org/D133800#3789100>, @aaron.ballman wrote:
>
>> In D133800#3788950 <https://reviews.llvm.org/D133800#3788950>, @nikic wrote:
>>
>>> I tested this patch as well and saw the same failures as @mgorny.
>>
>> Thank you, I think I've got those patched up, but with one difference:
>>
>>>   <snip>
>>>   diff --git a/clang/test/CodeGen/neon-crypto.c b/clang/test/CodeGen/neon-crypto.c
>>>   index 916886574416..1b29b1a53096 100644
>>>   --- a/clang/test/CodeGen/neon-crypto.c
>>>   +++ b/clang/test/CodeGen/neon-crypto.c
>>>   @@ -14,7 +14,7 @@
>>>    
>>>    uint8x16_t test_vaeseq_u8(uint8x16_t data, uint8x16_t key) {
>>>      // CHECK-LABEL: @test_vaeseq_u8
>>>   -  // CHECK-NO-CRYPTO: error: call to undeclared function 'vaeseq_u8'
>>>   +  // CHECK-NO-CRYPTO: warning: call to undeclared function 'vaeseq_u8'
>>>      return vaeseq_u8(data, key);
>>>      // CHECK: call <16 x i8> @llvm.{{arm.neon|aarch64.crypto}}.aese(<16 x i8> %data, <16 x i8> %key)
>>>    }
>>
>> Because this was the only `error` in the file, I changed the `RUN` line to remove the `not` in front of `%clang_cc1`, as that seemed like it would be necessary to get the test to pass as well.
>
> I'm afraid this version fails:
>
>   FAIL: Clang :: CodeGen/neon-crypto.c (4802 of 15654)
>   ******************** TEST 'Clang :: CodeGen/neon-crypto.c' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';   /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/15.0.0/include -nostdsysteminc -triple arm-none-linux-gnueabi -target-feature +neon   -target-feature +sha2 -target-feature +aes   -target-cpu cortex-a57 -emit-llvm -O1 -o - /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c | /usr/lib/llvm/15/bin/FileCheck /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   : 'RUN: at line 5';   /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/15.0.0/include -nostdsysteminc -triple arm64-none-linux-gnu -target-feature +neon    -target-feature +sha2 -target-feature +aes    -emit-llvm -O1 -o - /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c | /usr/lib/llvm/15/bin/FileCheck /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   : 'RUN: at line 8';   /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/15.0.0/include -nostdsysteminc -triple arm64-none-linux-gnu -target-feature +neon    -S -O3 -o - /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c 2>&1 | /usr/lib/llvm/15/bin/FileCheck --check-prefix=CHECK-NO-CRYPTO /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   --
>   Exit Code: 1
>   
>   Command Output (stderr):
>   --
>   + : 'RUN: at line 1'
>   + /usr/lib/llvm/15/bin/FileCheck /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   + /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/15.0.0/include -nostdsysteminc -triple arm-none-linux-gnueabi -target-feature +neon -target-feature +sha2 -target-feature +aes -target-cpu cortex-a57 -emit-llvm -O1 -o - /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   + : 'RUN: at line 5'
>   + /usr/lib/llvm/15/bin/FileCheck /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   + /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/15.0.0/include -nostdsysteminc -triple arm64-none-linux-gnu -target-feature +neon -target-feature +sha2 -target-feature +aes -emit-llvm -O1 -o - /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   + : 'RUN: at line 8'
>   + /usr/lib/llvm/15/bin/FileCheck --check-prefix=CHECK-NO-CRYPTO /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   + /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/15.0.0/include -nostdsysteminc -triple arm64-none-linux-gnu -target-feature +neon -S -O3 -o - /var/tmp/portage/sys-devel/clang-15.0.0-r1/work/clang/test/CodeGen/neon-crypto.c
>   
>   --
>   
>   ********************

Thanks for letting me know, I'll switch it back to include the `not` but... that's a surprise. It looks like it's been that way for ~9 years though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133800/new/

https://reviews.llvm.org/D133800