[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 22:27:39 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/include/clang/Driver/Compilation.h:134
+
+  llvm::SmallDenseMap<const JobAction *, const char *, 4> TimeTraceFiles;
+
----------------
I don't think we should use a non-zero inline element for these members.
They are, in 99.9%  cases, empty. We should optimize for the member size by making the number of inline element to 0.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133662/new/

https://reviews.llvm.org/D133662



More information about the cfe-commits mailing list