[PATCH] D133807: Update Unicode to 15.0

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 18:01:54 PDT 2022


cor3ntin added a comment.

Thanks for the review



================
Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713
+  // 8 characters
+  if (C <= 0xa7c2)
     return C | 1;
----------------
shafik wrote:
> Maybe I am misunderstanding the comments but should this be `0xa7be`?
Quirk of the script,  the comment for C|1 never make sense, the values seems correct though (this script is the only think i have not written myself)
https://github.com/llvm/llvm-project/blob/main/llvm/utils/unicode-case-fold.py#L89
So you have 8 even codepoints mapping to  C|1 + 7 odd codepoint mapping to C|1 which is C. If my math is correct.
I'm a bit reluctant to modify that script


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133807/new/

https://reviews.llvm.org/D133807



More information about the cfe-commits mailing list